badmanners/shimmie2
badmanners/shimmie2
Archived
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pm also used char for postgres

Browse source
This commit is contained in:
Shish 2020-10-26 17:28:21 +00:00
parent d18ac39e29
commit 08a4a6d41f
3 changed files with 9 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/database.php
View file

@ -356,7 +356,7 @@ class Database
return $this->db;
}
public function standardise_boolean(string $table, string $column): void
public function standardise_boolean(string $table, string $column, boolean $include_postgres=false): void
{
$d = $this->get_driver_name();
if ($d == DatabaseDriver::MYSQL) {
@ -373,5 +373,11 @@ class Database
# text, so we can in-place replace a char with a bool
$this->execute("UPDATE $table SET $column = ($column IN ('Y', 1))");
}
if ($d == DatabaseDriver::PGSQL) {
$this->execute("ALTER TABLE $table ADD COLUMN ${column}_b BOOLEAN DEFAULT FALSE NOT NULL");
$this->execute("UPDATE $table SET ${column}_b = ($column = 'Y')");
$this->execute("ALTER TABLE $table DROP COLUMN $column");
$this->execute("ALTER TABLE $table RENAME COLUMN ${column}_b TO $column");
}
}
}

3
ext/pm/main.php
View file

@ -96,7 +96,7 @@ class PrivMsg extends Extension
if ($config->get_int("pm_version") < 3) {
log_info("pm", "Updating is_read boolean");
$database->standardise_boolean("private_message", "is_read");
$database->standardise_boolean("private_message", "is_read", true);
$config->set_int("pm_version", 3);
log_info("pm", "extension upgraded");
}
@ -114,7 +114,6 @@ class PrivMsg extends Extension
}
}
public function onUserBlockBuilding(UserBlockBuildingEvent $event)
{
global $user;

15
ext/wiki/main.php
View file

@ -146,20 +146,7 @@ class Wiki extends Extension
$this->set_version("ext_wiki_version", 2);
}
if ($this->get_version("ext_wiki_version") < 3) {
$d = $database->get_driver_name();
if ($d == DatabaseDriver::MYSQL) {
$database->execute("ALTER TABLE wiki_pages MODIFY COLUMN locked BOOLEAN;");
$database->execute("UPDATE wiki_pages SET locked=0 WHERE locked=2;");
}
if ($d == DatabaseDriver::SQLITE) {
$database->execute("UPDATE wiki_pages SET locked = (locked IN ('Y', 1))");
}
if ($d == DatabaseDriver::PGSQL) {
$database->execute("ALTER TABLE wiki_pages ADD COLUMN locked_b BOOLEAN DEFAULT FALSE NOT NULL");
$database->execute("UPDATE wiki_pages SET locked_b = (locked = 'Y')");
$database->execute("ALTER TABLE wiki_pages DROP COLUMN locked");
$database->execute("ALTER TABLE wiki_pages RENAME COLUMN locked_b TO locked");
}
$database->standardise_boolean("wiki_pages", "locked", true);
$this->set_version("ext_wiki_version", 3);
}
}