badmanners/shimmie2
badmanners/shimmie2
Archived
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[statistics] sort by tag id for correctness

Browse source 
Sorting by user.id was an oversight which caused tags to be miscredited when comparing against the previous tag history entry for an image. For example, whoever had the lowest user ID (rather than the uploader) had their entry considered the initial tag list.
This commit is contained in:
discomrade 2024-06-17 01:30:03 +00:00 committed by Shish
parent d7f0f17fea
commit 2a9228e244
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/statistics/main.php
View file

@ -95,7 +95,7 @@ class Statistics extends Extension
{
global $database;
// Returns the username and tags from each tag history entry. This includes Anonymous tag histories to prevent their tagging being ignored and credited to the next user to edit.
$tag_stats = $database->get_all("SELECT users.class,users.name,tag_histories.tags,tag_histories.image_id FROM tag_histories INNER JOIN users ON users.id = tag_histories.user_id WHERE 1=1 ORDER BY users.id;");
$tag_stats = $database->get_all("SELECT users.class,users.name,tag_histories.tags,tag_histories.image_id FROM tag_histories INNER JOIN users ON users.id = tag_histories.user_id WHERE 1=1 ORDER BY tag_histories.id;");
// Group tag history entries by image id
$tag_histories = [];