badmanners/shimmie2
badmanners/shimmie2
Archived
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

optimise tag setting

Browse source
This commit is contained in:
Shish 2023-06-25 14:59:10 +00:00
parent e66acefa53
commit 32f2ab8eb6
2 changed files with 52 additions and 63 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

86
core/imageboard/image.php
View file

@ -640,27 +640,15 @@ class Image
public function delete_tags_from_image(): void public function delete_tags_from_image(): void
{ {
global $database; global $database;
if ($database->get_driver_id() == DatabaseDriverID::MYSQL) { $database->execute("
//mysql < 5.6 has terrible subquery optimization, using EXISTS / JOIN fixes this UPDATE tags
$database->execute( SET count = count - 1
" WHERE id IN (
UPDATE tags t SELECT tag_id
INNER JOIN image_tags it ON t.id = it.tag_id FROM image_tags
SET count = count - 1 WHERE image_id = :id
WHERE it.image_id = :id", )
["id"=>$this->id] ", ["id"=>$this->id]);
);
} else {
$database->execute("
UPDATE tags
SET count = count - 1
WHERE id IN (
SELECT tag_id
FROM image_tags
WHERE image_id = :id
)
", ["id"=>$this->id]);
}
$database->execute(" $database->execute("
DELETE DELETE
FROM image_tags FROM image_tags
@ -699,51 +687,23 @@ class Image
// delete old // delete old
$this->delete_tags_from_image(); $this->delete_tags_from_image();
$written_tags = [];
// insert each new tags // insert each new tags
foreach ($tags as $tag) { foreach ($tags as $tag) {
$id = $database->get_one( $id = Tag::get_or_create_id($tag);
" $database->execute("
SELECT id INSERT INTO image_tags(image_id, tag_id)
FROM tags VALUES(:iid, :tid)
WHERE LOWER(tag) = LOWER(:tag) ", ["iid"=>$this->id, "tid"=>$id]);
",
["tag"=>$tag]
);
if (empty($id)) {
// a new tag
$database->execute(
"INSERT INTO tags(tag) VALUES (:tag)",
["tag"=>$tag]
);
$database->execute(
"INSERT INTO image_tags(image_id, tag_id)
VALUES(:id, (SELECT id FROM tags WHERE LOWER(tag) = LOWER(:tag)))",
["id"=>$this->id, "tag"=>$tag]
);
} else {
// check if tag has already been written
if (in_array($id, $written_tags)) {
continue;
}
$database->execute("
INSERT INTO image_tags(image_id, tag_id)
VALUES(:iid, :tid)
", ["iid"=>$this->id, "tid"=>$id]);
$written_tags[] = $id;
}
$database->execute(
"
UPDATE tags
SET count = count + 1
WHERE LOWER(tag) = LOWER(:tag)
",
["tag"=>$tag]
);
} }
$database->execute("
UPDATE tags
SET count = count + 1
WHERE id IN (
SELECT tag_id
FROM image_tags
WHERE image_id = :id
)
", ["id"=>$this->id]);
log_info("core_image", "Tags for Post #{$this->id} set to: ".Tag::implode($tags)); log_info("core_image", "Tags for Post #{$this->id} set to: ".Tag::implode($tags));
$cache->delete("image-{$this->id}-tags"); $cache->delete("image-{$this->id}-tags");

29
core/imageboard/tag.php
View file

@ -90,6 +90,35 @@ class TagUsage
*/ */
class Tag class Tag
{ {
private static $tag_id_cache = [];
public static function get_or_create_id(string $tag): int
{
global $database;
if(in_array($tag, self::$tag_id_cache)) {
return self::$tag_id_cache[$tag];
}
$id = $database->get_one(
"SELECT id FROM tags WHERE LOWER(tag) = LOWER(:tag)",
["tag"=>$tag]
);
if (empty($id)) {
// a new tag
$database->execute(
"INSERT INTO tags(tag) VALUES (:tag)",
["tag"=>$tag]
);
$id = $database->get_one(
"SELECT id FROM tags WHERE LOWER(tag) = LOWER(:tag)",
["tag"=>$tag]
);
}
self::$tag_id_cache[$tag] = $id;
return $id;
}
public static function implode(array $tags): string public static function implode(array $tags): string
{ {
sort($tags); sort($tags);