badmanners/shimmie2
badmanners/shimmie2
Archived
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[core] load null-strings as null, fixes #1023

Browse source
This commit is contained in:
Shish 2024-02-12 16:03:37 +00:00
parent 29ff1b7333
commit 3d905b1055
2 changed files with 29 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
core/imageboard/image.php
View file

@ -90,13 +90,18 @@ class Image implements \ArrayAccess
$t = (new \ReflectionProperty($this, $name))->getType();
assert(!is_null($t));
if(is_a($t, \ReflectionNamedType::class)) {
if(is_null($value)) {
$this->$name = null;
} else {
$this->$name = match($t->getName()) {
"int" => is_null($value) ? $value : int_escape((string)$value),
"bool" => is_null($value) ? $value : bool_escape((string)$value),
"int" => int_escape((string)$value),
"bool" => bool_escape((string)$value),
"string" => (string)$value,
default => $value,
};
}
}
} elseif(array_key_exists($name, static::$prop_types)) {
if (is_null($value)) {
$value = null;

18
core/tests/ImageTest.php Normal file
View file

@ -0,0 +1,18 @@
<?php
declare(strict_types=1);
namespace Shimmie2;
require_once "core/imageboard/image.php";
class ImageTest extends ShimmiePHPUnitTestCase
{
public function testLoadData(): void
{
$this->log_in_as_user();
$image_id_1 = $this->post_image("tests/pbx_screenshot.jpg", "question? colon:thing exclamation!");
$image = Image::by_id($image_id_1);
$this->assertNull($image->source);
}
}