From 4e789040a011bb3cbec963d9cf4e31e346b6aa49 Mon Sep 17 00:00:00 2001
From: Shish <shish@shishnet.org>
Date: Mon, 15 Jan 2024 14:21:33 +0000
Subject: [PATCH] [core] don't pass strings to functions that want ints

---
 ext/artists/main.php       | 6 +++---
 ext/ouroboros_api/main.php | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ext/artists/main.php b/ext/artists/main.php
index 00311720..9d401eaa 100644
--- a/ext/artists/main.php
+++ b/ext/artists/main.php
@@ -564,7 +564,7 @@ class Artists extends Extension
         // ALIAS MATCHING SECTION
         $i = 0;
         $aliasesAsArray = is_null($aliasesAsString) ? [] : explode(" ", $aliasesAsString);
-        $aliasesIDsAsArray = is_null($aliasesIDsAsString) ? [] : explode(" ", $aliasesIDsAsString);
+        $aliasesIDsAsArray = is_null($aliasesIDsAsString) ? [] : array_map(fn ($n) => int_escape($n), explode(" ", $aliasesIDsAsString));
         while ($i < count($aliasesAsArray)) {
             // if an alias was updated
             if ($i < count($aliasesIDsAsArray)) {
@@ -584,7 +584,7 @@ class Artists extends Extension
         // MEMBERS MATCHING SECTION
         $i = 0;
         $membersAsArray = is_null($membersAsString) ? [] : explode(" ", $membersAsString);
-        $membersIDsAsArray = is_null($membersIDsAsString) ? [] : explode(" ", $membersIDsAsString);
+        $membersIDsAsArray = is_null($membersIDsAsString) ? [] : array_map(fn ($n) => int_escape($n), explode(" ", $membersIDsAsString));
         while ($i < count($membersAsArray)) {
             // if a member was updated
             if ($i < count($membersIDsAsArray)) {
@@ -606,7 +606,7 @@ class Artists extends Extension
         $urlsAsString = str_replace("\r\n", "\n", $urlsAsString);
         $urlsAsString = str_replace("\n\r", "\n", $urlsAsString);
         $urlsAsArray = empty($urlsAsString) ? [] : explode("\n", $urlsAsString);
-        $urlsIDsAsArray = is_null($urlsIDsAsString) ? [] : explode(" ", $urlsIDsAsString);
+        $urlsIDsAsArray = is_null($urlsIDsAsString) ? [] : array_map(fn ($n) => int_escape($n), explode(" ", $urlsIDsAsString));
         while ($i < count($urlsAsArray)) {
             // if an URL was updated
             if ($i < count($urlsIDsAsArray)) {
diff --git a/ext/ouroboros_api/main.php b/ext/ouroboros_api/main.php
index 7827e658..571d9870 100644
--- a/ext/ouroboros_api/main.php
+++ b/ext/ouroboros_api/main.php
@@ -262,7 +262,7 @@ class OuroborosAPI extends Extension
                     throw new SCoreException("update not implemented");
                 } elseif ($this->match('show')) {
                     // Show
-                    $id = !empty($_REQUEST['id']) ? filter_var($_REQUEST['id'], FILTER_SANITIZE_NUMBER_INT) : null;
+                    $id = !empty($_REQUEST['id']) ? (int)filter_var($_REQUEST['id'], FILTER_SANITIZE_NUMBER_INT) : null;
                     $this->postShow($id);
                 } elseif ($this->match('index') || $this->match('list')) {
                     // List