badmanners/shimmie2
badmanners/shimmie2
Archived
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #481 from jgen/develop

Browse source 
Fix XSS in arrowkey extension
This commit is contained in:
Shish 2015-03-13 08:37:08 +00:00
commit 519749559f
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/event.class.php
View file

@ -118,7 +118,7 @@ class PageRequestEvent extends Event {
* @return int
*/
public function count_args() {
return (int)($this->arg_count - $this->part_count);
return int_escape($this->arg_count - $this->part_count);
}
/*

6
ext/arrowkey_navigation/main.php
View file

@ -69,13 +69,13 @@ class ArrowkeyNavigation extends Extension {
// if there are no tags, use default
if ($event->get_arg(1) == null){
$prefix = "";
$page_number = (int)$event->get_arg(0);
$page_number = int_escape($event->get_arg(0));
$total_pages = ceil($database->get_one(
"SELECT COUNT(*) FROM images") / $images_per_page);
}
else { // if there are tags, use pages with tags
$prefix = $event->get_arg(0)."/";
$page_number = (int)$event->get_arg(1);
$prefix = url_escape($event->get_arg(0)) . "/";
$page_number = int_escape($event->get_arg(1));
$total_pages = ceil($database->get_one(
"SELECT count FROM tags WHERE tag=:tag",
array("tag"=>$event->get_arg(0))) / $images_per_page);