diff --git a/ext/media/main.php b/ext/media/main.php index b2099423..860d8c1a 100644 --- a/ext/media/main.php +++ b/ext/media/main.php @@ -286,10 +286,6 @@ class Media extends Extension $matches = []; if (preg_match(self::CONTENT_SEARCH_TERM_REGEX, strtolower($event->term), $matches) && $event->parse) { - // Nothing to save, just helping filter out reserved tags - } - - if (!empty($matches)) { $event->metatag = true; } } diff --git a/ext/ouroboros_api/main.php b/ext/ouroboros_api/main.php index cea20920..592c397a 100644 --- a/ext/ouroboros_api/main.php +++ b/ext/ouroboros_api/main.php @@ -390,8 +390,7 @@ class OuroborosAPI extends Extension $this->sendResponse(403, 'You cannot create new posts'); } } elseif ($this->match('update')) { - // Update - //@todo add post update + throw new SCoreException("update not implemented"); } elseif ($this->match('show')) { // Show $id = !empty($_REQUEST['id']) ? filter_var($_REQUEST['id'], FILTER_SANITIZE_NUMBER_INT) : null; diff --git a/ext/setup/main.php b/ext/setup/main.php index bbec0012..7003c8eb 100644 --- a/ext/setup/main.php +++ b/ext/setup/main.php @@ -53,10 +53,7 @@ class SetupBlock extends Block public function __construct(string $title) { - $this->header = $title; - $this->section = "main"; - $this->position = 50; - $this->body = ""; + parent::__construct($title, "", "main", 50); } public function add_label(string $text) diff --git a/ext/source_history/main.php b/ext/source_history/main.php index a000e28f..dfcec726 100644 --- a/ext/source_history/main.php +++ b/ext/source_history/main.php @@ -301,10 +301,7 @@ class SourceHistory extends Extension ORDER BY date_set DESC LIMIT 1 ', $select_args); - if (empty($row)) { - // we can not revert this image based on the date restriction. - // Output a message perhaps? - } else { + if (!empty($row)) { $revert_id = $row['id']; $result = $this->get_source_history_from_revert($revert_id); diff --git a/ext/tag_history/main.php b/ext/tag_history/main.php index a956b17a..f1163eee 100644 --- a/ext/tag_history/main.php +++ b/ext/tag_history/main.php @@ -302,10 +302,7 @@ class TagHistory extends Extension ORDER BY date_set DESC LIMIT 1 ', $select_args); - if (empty($row)) { - // we can not revert this image based on the date restriction. - // Output a message perhaps? - } else { + if (!empty($row)) { $revert_id = $row['id']; $result = $this->get_tag_history_from_revert($revert_id); diff --git a/ext/user/main.php b/ext/user/main.php index 7a6c08c2..a61105ed 100644 --- a/ext/user/main.php +++ b/ext/user/main.php @@ -430,7 +430,7 @@ class UserPage extends Extension } elseif (is_null($my_user->email)) { $this->theme->display_error(400, "Error", "That user has no registered email address"); } else { - // send email + throw new SCoreException("Email sending not implemented"); } }