jgen
76fd27f87c
Fixing/Cleaning more PHP Doc related issues.
2014-04-28 00:56:19 -04:00
jgen
8a2eb4b121
Fixing more PHP Doc related issues.
2014-04-27 19:29:36 -04:00
jgen
4f51e942be
Updating/Fixing/Adding more comments with the PHP Doc style.
2014-04-27 15:33:57 -04:00
jgen
b1d123c960
Add more escaping to the shell command for ffmpeg.
2014-04-26 17:09:18 -04:00
jgen
2e4b53c3f4
Merge branch 'code_removal' of github.com:jgen/shimmie2 into develop
2014-04-26 16:55:11 -04:00
jgen
1ecf33e39d
Merge branch 'video_thumb' of git://github.com/shish/shimmie2 into develop
2014-04-26 16:54:28 -04:00
jgen
86b6d12819
Merge branch 'linting' of github.com:jgen/shimmie2 into code_removal
2014-04-26 16:50:14 -04:00
jgen
95ba85ee43
This js file relies on functions defined in 'shimmie.js' which is all globed together when rendering a page. Adding an ignore line to scrutinizer to prevent false-positives.
2014-04-26 05:32:15 -04:00
jgen
a8dd045586
Combine these if statements into one to reduce the cyclomatic complexity.
2014-04-26 03:56:06 -04:00
jgen
42407116a8
Removing this file.
2014-04-26 03:33:20 -04:00
jgen
013222e4ee
Code Removal: PHP has had JSON support directly baked into the language since 5.2.0 - there is no need to rely on an external library from 2006 for json support.
2014-04-26 03:31:02 -04:00
jgen
298344048c
Make these functions public to prevent scrutinizer from complaining.
2014-04-26 00:27:16 -04:00
jgen
1ca3865a1c
Removing the closing PHP "?>" tag as per style guidelines. (Also see: https://stackoverflow.com/questions/4410704/why-would-one-omit-the-close-tag )
2014-04-25 22:54:51 -04:00
jgen
3e899710d7
Stop scrutinizer from complaining here.
2014-04-25 17:40:42 -04:00
jgen
c85630198f
These variables where never defined depending on the execution path.
2014-04-25 17:40:14 -04:00
jgen
6f685ca227
Use the method from core/util to parse the bool from the DB instead.
2014-04-25 17:39:46 -04:00
jgen
3a1197256a
Need to pull in the global $page variable for this method.
2014-04-25 17:39:06 -04:00
jgen
1e15c5e47a
Explicitly declare this class variable
2014-04-25 17:38:25 -04:00
jgen
bcd3f991de
Removing the closing PHP "?>" tag as per style guidelines.
2014-04-25 17:34:20 -04:00
jgen
b4e6c0b743
Explicitly check if we can actually find the image by Id.
2014-04-25 16:08:00 -04:00
jgen
478eb3a4cc
Linting: Check for null return value, and throw an exception if null.
2014-04-25 15:39:00 -04:00
jgen
7ef68b15f9
Fix indentation.
2014-04-25 15:38:15 -04:00
jgen
b241390fa4
Removing the closing PHP "?>" tag as per style guidelines.
2014-04-24 22:34:45 -04:00
jgen
50686ac61e
More linting, fix PHPDoc style.
2014-04-24 22:29:29 -04:00
jgen
daee99c1bc
Removing the closing PHP "?>" tag as per style guidelines.
2014-04-24 22:28:53 -04:00
jgen
860af25550
Need to pull in the global $user variable.
2014-04-24 22:22:45 -04:00
jgen
4ec5a7ce52
Removing the closing PHP "?>" tag as per style guidelines.
2014-04-24 22:22:16 -04:00
jgen
780d5f8709
More linting. Explicitly declare these class variables, as well as comment out dead code.
2014-04-24 22:13:00 -04:00
jgen
6e4ae229ef
Explicitly declare this class variable
2014-04-24 19:13:41 -04:00
jgen
4cc31df737
Update the comments to PHPDoc style guidelines.
2014-04-24 19:02:43 -04:00
jgen
ab3f9850e4
Removing the closing PHP "?>" tag as per style guidelines.
2014-04-24 19:01:47 -04:00
jgen
709366b70c
Explicitly declare these class variables.
2014-04-24 18:44:46 -04:00
jgen
7b90331f02
Add missing semi-colon.
2014-04-24 16:56:04 -04:00
jgen
e2f5c7a6ec
Check for null, just in case.
2014-04-24 05:09:38 -04:00
jgen
332c8538b7
Change the function syntax to quiet JSHint.
2014-04-24 04:46:23 -04:00
jgen
506e699f8a
Not sure if we really need the triple equals.
2014-04-24 01:15:30 -04:00
jgen
866d39a68e
The 'tags' box actually has a different ID.
2014-04-24 01:15:03 -04:00
jgen
51c145d5c9
Some more linting on the bookmarklet.js file.
2014-04-24 01:08:47 -04:00
jgen
4b90faf89d
Even more linting of JS files.
2014-04-24 00:55:14 -04:00
jgen
a105090039
Some more JS linting.
2014-04-23 23:39:09 -04:00
jgen
887f963e17
Add the jshint comment to alter how scrutinzer-ci deals with the js.
2014-04-23 23:38:53 -04:00
jgen
b775c007cd
Give these HTML headers some slight priority over the default value of 50.
2014-04-23 23:07:10 -04:00
jgen
a0ab3864c0
Push the headers for the chatbox even further down to make sure that jQuery is already loaded.
2014-04-23 23:01:51 -04:00
jgen
8cdf919827
More linting. This time of the JavaScript for the chat-box extension.
2014-04-23 22:43:42 -04:00
jgen
0bd031a269
Merge branch 'develop' of github.com:jgen/shimmie2 into linting
...
Manually resolved conflicts:
ext/chatbox/js/yshout.js
2014-04-23 22:42:30 -04:00
jgen
21e1359b86
Avoid short open tag for PHP.
2014-04-20 05:07:26 -04:00
jgen
60980c8839
One more jQuery reference.
2014-04-20 05:04:45 -04:00
jgen
a7ba0f887b
Again, the chatbox needs help from the jQuery migrate plugin.
2014-04-20 05:00:59 -04:00
jgen
2df54b911a
Don't use short open tags for PHP as they are not turned on by default in production environments.
2014-04-20 05:00:34 -04:00
jgen
e2516fa5cf
Chatbox should be fixed now.
...
The chatbox extension actually needs some functionality that was removed from jQuery versions 1.9 and up. When Shimmie's version of jQuery was bumped up to 1.11 this actually broke the chatbox.
2014-04-20 04:51:19 -04:00
jgen
880840623a
Need to ensure that this html header is added last.
2014-04-20 04:36:25 -04:00
jgen
717401ccab
Removing this as jQuery is already included in Shimmie now.
2014-04-20 04:35:33 -04:00
jgen
8b698e1b6f
Revert this commit.
2014-04-20 04:29:11 -04:00
jgen
54362a49c6
Fix the broken chatbox issue.
2014-04-20 04:25:08 -04:00
jgen
57a390eaab
Massive linting!
2014-04-19 23:38:42 -04:00
Shish
dc6653d3be
Merge pull request #407 from jgen/hotfix/downtime_theme_edits
...
Hotfix/downtime theme edits
2014-04-20 00:30:57 +01:00
Shish
75c3d8e453
Merge pull request #409 from jgen/linting
...
Linting
2014-04-20 00:29:53 +01:00
jgen
c527ae91d6
More linting and cleanup.
2014-04-19 04:17:28 -04:00
jgen
be385deaab
Clean up this js file as well.
2014-04-19 02:58:36 -04:00
jgen
28d83fda0d
Even more linting and cleaning.
2014-04-19 02:33:34 -04:00
jgen
2da8c19a07
More linting!
2014-04-19 01:36:18 -04:00
jgen
bdf49b33cb
Some more linting thanks to scrutinizer-ci
2014-04-19 01:18:49 -04:00
jgen
505a3e5233
Merge branch 'develop' of git://github.com/shish/shimmie2 into hotfix/downtime_theme_edits
2014-04-18 20:25:36 -04:00
jgen
71d7474476
Add <section> tags to the downtime page so that theme render correctly.
2014-04-18 20:21:50 -04:00
jgen
7fd655fc4e
Added conditional message for IE users to download plugin from Google for webm.
2014-04-18 18:47:14 -04:00
jgen
b5d005710c
Fix indentation (spaces -> tabs)
2014-04-18 02:10:10 -04:00
jgen
2f380f5d59
Video thumbs are working for webm files now.
2014-04-18 02:06:12 -04:00
jgen
273d386d22
Working on thumbnail support for video files.
2014-04-18 01:37:27 -04:00
Justin Brewer
f243092634
count("") == 1
2014-04-11 23:55:30 -04:00
Shish
6c9a4a3b86
A start on video thumbnailing; see #400
...
Almost certainly not working yet; not tested, just committing so that
other people have something to work with and we aren't duplicating
effort
2014-04-10 08:15:00 +01:00
Jeff Genovy
3a0da5df5a
Merge pull request #399 from Diftraku/ouroboros_api
...
Special chars in tags barf filter_var
2014-04-09 22:33:05 -04:00
Diftraku
7ac61f4234
Special chars in tags barf filter_var
...
Due to how FILTER_SANITIZE_STRING works, if you had special chars in
your tags (eg. <3 or !) the string would be cut before the offending
character(s) and in worst case, result in no tags passing to the API
2014-04-10 04:11:43 +03:00
jgen
3c6b8b6fe6
Merge branch 'linting' of git://github.com/shish/shimmie2 into develop
...
Conflicts:
ext/resize/main.php
2014-04-09 15:04:18 -04:00
Shish
f72bfbb050
fix indentation
2014-04-06 20:47:01 +01:00
Daku
f88ba20319
Merge pull request #393 from shish/resize_tweak
...
pass already fetched image object into resize()
2014-04-04 17:38:08 +01:00
Daku
2d25d43ecf
Merge pull request #389 from HungryFeline/patch-1
...
Redirect to default page if referer isn't set
2014-04-04 17:30:19 +01:00
Shish
a0d1948a4f
pass already fetched image object into resize(), rather than passing the ID to be re-fetched
2014-04-02 08:49:13 +01:00
jgen
1e49cc9122
More comments and fix undefined variables.
2014-04-01 22:02:36 -04:00
jgen
9b1c3db400
Slight re-word of the exception error message.
2014-04-01 21:43:12 -04:00
jgen
18b8e7912f
Fix warning generated when an image doesn't have bits or channel info (and use sane defaults).
2014-04-01 21:42:40 -04:00
jgen
225d197790
Remove duplicate code.
2014-04-01 21:41:57 -04:00
jgen
749f846b79
Fix typo.
2014-04-01 20:33:36 -04:00
jgen
a442fbe409
Resizing images actually was broken, how nobody noticed I don't know.
2014-04-01 19:29:31 -04:00
Shish
c8aa3327a1
A bunch of small changes from scrutinizer-ci; some tidying, some actual bug fixes
2014-03-30 13:26:48 +01:00
Shish
db5aa56300
remove a bunch of dead code
2014-03-29 11:44:34 +00:00
HungryFeline
c215d6991a
Redirect to default page if referer isn't set
...
Instead of displaying `You should be redirected to <a href=""></a>`
2014-03-27 09:57:43 +01:00
Shish
7a95325a5f
Merge pull request #388 from DakuTree/patch
...
Fixes issues 233 & 234.
2014-03-26 10:41:31 +00:00
Daku
7837362711
make sure source is still used if provided
2014-03-26 08:26:21 +00:00
Daku
994652c3f7
make sure mass_tag_edit reads high > low id if default order is different
2014-03-26 08:05:05 +00:00
Shish
7b68d8ebfd
use new-style constructors everywhere
2014-03-22 09:00:59 +00:00
Shish
da29912646
tidy up a bunch of lint errors
2014-03-17 22:05:37 +00:00
Daku
76526f371c
Add option to use transloaded URL as source
...
fixes #234
2014-03-14 16:54:14 +00:00
Daku
5f3ff8db86
don't add "tagme" when trying to mass-edit to null
...
fixes #233
2014-03-13 23:29:47 +00:00
Daku
4351dc53c5
make sure all existing exts are converted to lowercase
2014-03-08 15:27:39 +00:00
Daku
258fda188e
use different selector rather than hardcoding url
2014-03-08 15:20:50 +00:00
Daku
ddb6d32e29
fix fourm errors under postgresql
2014-03-02 21:59:19 +00:00
Daku
87065d08f6
use elseif
2014-03-02 21:58:45 +00:00
Daku
524ead8344
PostgreSQL doesn't return trimmed results for CHAR columns, so use VARCHAR instead
2014-03-02 21:07:25 +00:00
Daku
a863072bfb
DATETIME > SCORE_DATETIME
...
fixes #354
2014-03-02 18:50:46 +00:00
Daku
53a7e23b64
various autocomplete tweaks
...
* made limit for /api/internal/tag_list/complete optional (as this breaks the autocomplete on dbs with lots of tags)
* removed delay + minChars = 1 again (due to above change)
* first autocomplete tag is selected by default
* tab now works as a select button
* autocompleted tags will now be followed by a space (so the next tag can be instantly autocompleted)
2014-02-28 02:03:41 +00:00
Daku
d675827173
order[=|:]random_#### metatag
...
possible replacement for random_list ext?
2014-02-24 19:54:15 +00:00
Daku
320a92289b
have query use EXISTS rather than IN
...
preferably we would have a table with image tag counts, but this works for now
2014-02-24 01:50:31 +00:00
Daku
790cb0d7a9
[.+]tags metatag for tag_categories
...
This is nowhere as near as fast as I'd like. Need to find a better query.
2014-02-24 01:40:35 +00:00
Daku
bdb3255116
speed: lowercase ext on image insert
...
avoids having to lowercase every build_thumb_html call
most extensions tend to match against their lowercase versions anyway
2014-02-23 22:27:52 +00:00
jgen
cebc197fba
Merge branch 'develop' of git://github.com/shish/shimmie2
2014-02-23 03:11:09 -05:00
jgen
6f59de4d45
Prevent an internal server error occurring when mincount is less than 1.
2014-02-23 02:51:33 -05:00
jgen
2b4ffb1e60
Argh.
2014-02-23 02:18:45 -05:00
jgen
38b494125c
Postgres requires you to include the GROUP BY column in the SELECT columns. Should be okay since we don't care about other columns though.
2014-02-23 02:15:19 -05:00
jgen
cf35bf82a8
Postgres doesn't support the DATETIME field.
2014-02-22 23:30:58 -05:00
jgen
e30520a5ef
Fixing typo.
2014-02-22 23:23:23 -05:00
jgen
9892d1f7fd
PostgreSQL does not support INDEX() inside the CREATE TABLE method. You must create the index as a separate query. Fortunately MySQL also support this way of doing things as well.
2014-02-22 23:02:11 -05:00
jgen
3d1217a1be
Trim trailing blank space.
2014-02-22 15:36:52 -05:00
jgen
96358f0bc0
Nevermind, it doesn't work.
2014-02-22 15:33:55 -05:00
jgen
2d0edde2b2
We can check that admin users see the "Add" button though.
2014-02-22 15:25:25 -05:00
jgen
d6f0213a9f
Commenting out the alias tests due to consistent failing on TravisCI.
2014-02-22 15:19:06 -05:00
jgen
6efe56eddf
Well, lets try this.
2014-02-22 03:10:59 -05:00
jgen
b229e114c2
Dump all the post data on failure.
2014-02-22 03:06:09 -05:00
jgen
f1aed15f32
die doesn't support commas
2014-02-22 02:59:17 -05:00
jgen
cbfc0580f6
Temporary for debugging.
2014-02-22 02:35:56 -05:00
jgen
ba0aef4f30
The Database class should really throw an error here. This will likely break the existing tests.
2014-02-22 00:40:14 -05:00
jgen
bbfba90ad4
Merge pull request #380 from DakuTree/patch-3
...
Misc tweaks/fixes 2 (fixes #349 )
2014-02-21 13:40:52 -05:00
jgen
f4f94e6273
Merge pull request #379 from DakuTree/patch-2
...
Misc tweaks/fixes (fixes/closes issue 17 & 323)
2014-02-21 13:40:15 -05:00
jgen
e8cba99111
Merge pull request #378 from DakuTree/patch
...
Post Relationships ext + TagTermParseEvent
2014-02-21 13:32:33 -05:00
jgen
9255c861f7
Cleaning up.
2014-02-19 20:50:00 -05:00
jgen
f3c379b8db
Rename the file.
2014-02-19 18:36:38 -05:00
jgen
eea4d34978
We can actually push the trim functions to when we create the define, less overhead.
2014-02-19 18:17:26 -05:00
jgen
141be8768f
Better detection of running on the command line.
2014-02-19 18:10:40 -05:00
jgen
5a49bb59e4
Check that regular users can't add aliases.
2014-02-19 17:03:35 -05:00
jgen
1a7cbc9b2a
Check the actual http response code.
2014-02-19 16:40:28 -05:00
jgen
f1a516ef18
Extra debugging when Alias fails.
2014-02-19 16:24:47 -05:00
jgen
bdbb280064
Fixing the alias test cases.
2014-02-19 04:27:29 -05:00
jgen
55f07d0cfd
Fix the tag_edit tests.
2014-02-19 04:15:00 -05:00
jgen
8b0ac0e9c1
The location of the webserver should be configurable in the travis file.
2014-02-19 03:29:12 -05:00
Daku
fe6b83412f
use jQuery instead of JS + change spacing to tabs
...
this should fix IE/browser problems (see: #349 )
2014-02-19 06:23:08 +00:00
Daku
5df6c09da6
reset_image_ids should properly change id for all possible tables
2014-02-19 05:48:20 +00:00
jgen
66f32e63cf
These tests for Mass tagger only work with NiceURLs enabled. Commenting them out for now.
2014-02-18 17:02:41 -05:00
Daku
daad8d00d5
fix download all images not working
2014-02-18 12:33:10 +00:00
Daku
5a4b089a61
fix database_dump regex not working with no password
2014-02-18 08:20:52 +00:00
Daku
857f7e4041
don't force hellban ext + add [Beta] tags
2014-02-18 07:24:26 +00:00
jgen
8a700a34fc
No idea why it was set to use the directory "2.Xm"
2014-02-17 14:46:00 -05:00
jgen
fe83e3d343
Adding comments to help explain the simpletest setup.
2014-02-17 13:59:41 -05:00
jgen
c05b4719d6
Fix the tests for the Alias extension.
2014-02-17 01:52:30 -05:00
jgen
807b0c7037
Commenting this out as it assumes Nice URLs, and fails if they are not enabled.
2014-02-17 01:51:40 -05:00
jgen
073813d0ea
Fix the warning that these variables aren't defined.
2014-02-17 01:49:16 -05:00
Daku
7c36902537
updated js libs
...
jQuery 1.7.1 > 1.11.0
jQuery UI custom (highlight effect) 1.10.3 > 1.10.4
jQuery autocomplete 1.1 > 2.4.4
jQuery imgareaselect 0.4 > 1.0.0
jQuery imgnotes 0.2 > 1.0
jQuery tablesorter ? > 2.0.5
jQuery timeago 1.1.1 > 1.3.1
Modernizer 2.5.3 > 2.7.1
2014-02-17 03:02:14 +00:00
jgen
3cb79f0e8a
SimpleTest works now.
2014-02-16 19:36:52 -05:00
Daku
c51d1388c0
remove lazyload lib + make random list ext more readable
...
lazyload is no longer used, see: 7c95981319
2014-02-16 23:24:05 +00:00
Daku
c065e38145
adds widget/thumb option to random_thumb ext (for #323 )
...
this code was suggested in the comments, but never actually added
2014-02-16 04:38:58 +00:00
Daku
e8607ab6f2
cleaned up popular_by pages
...
my old code was so messy :<
2014-02-16 02:29:16 +00:00
Daku
eb16ab09ed
order images sorted by score
...
this is solution for issue #17 (Method to sort by top scored images in numeric_score module)
2014-02-16 02:28:39 +00:00