Commit graph

228 commits

Author SHA1 Message Date
Shish
247cfcbd77 Avoid shadowing global variable
When we aren't referencing the current `global $user`, we should give it
a different name to avoid confusion
2019-11-11 16:43:42 +00:00
Shish
f79eafc91e format 2019-11-04 00:42:06 +00:00
Shish
d17e207984 Have get_arg never return null
90% of places assume it will never return null, and they will break in
weird ways if it does return null
2019-11-04 00:40:10 +00:00
Shish
f15a95b4de more version 2019-11-03 19:49:52 +00:00
Shish
0e660f5aba mysql... 2019-11-03 19:15:09 +00:00
Shish
c58a13ae88 formatting 2019-11-03 18:28:38 +00:00
Shish
6bc33ee691 Drop SCORE_DATETIME/NOW - all the databases we care about now support TIMESTAMP/CURRENT_TIMESTAMP 2019-11-03 18:28:05 +00:00
Shish
031c441e47 split DatabaseUpgrade into a separate event from InitExt 2019-11-03 17:21:05 +00:00
Shish
ac5546c6ef remove more old comments 2019-11-03 16:22:59 +00:00
Shish
30698fefdc remove a bunch of dead variables and things 2019-10-02 11:23:57 +01:00
Shish
e08cdb1638 make Cache its own thing, separate from Database 2019-10-02 10:49:32 +01:00
Shish
54067f02a4 fix merge 2019-09-29 15:44:59 +01:00
Shish
e6a402cd4e Merge branch 'custom_ratings' into develop 2019-09-29 14:41:14 +01:00
Shish
f5119b20a3 formatting 2019-09-29 14:32:51 +01:00
Shish
a6bb15d859 formatting 2019-09-29 14:30:55 +01:00
Matthew Barbour
b2193cb6f1 Adjusted rating array usage 2019-08-07 15:49:57 -05:00
Matthew Barbour
68ee4d0e77 Custom rating support, user rating filter settings 2019-08-07 15:49:26 -05:00
Matthew Barbour
de98e86938 ExtensionInfo conversions what have I done 2019-08-07 15:40:01 -05:00
Matthew Barbour
a18589ee0a Help extension
Provides foundation for help pages that are generated from loaded extensions, starting with comprehensive search documentation. Addresses #522
2019-08-05 09:03:49 -05:00
Matthew Barbour
00464d2579 Implemented a nav link generating system so that extension power what shows up in the menus rather than being hard-coded in the themes. 2019-08-05 09:01:20 -05:00
Matthew Barbour
cb1e9c0075 Permissions to constants 2019-08-01 08:07:05 -05:00
Matthew Barbour
1370afec72 Moved database driver constants to DatabaseDriver 2019-06-20 10:47:15 -05:00
Matthew Barbour
826c623538 PageMode constants 2019-06-18 21:04:31 -05:00
Matthew Barbour
6f501a6e74 Database driver constants 2019-06-14 13:38:47 -05:00
Shish
2396ae2ef9 fix a bunch of lints 2019-05-28 20:27:23 +01:00
Shish
34b05cca7c PSR-2. I'm not a huge fan, but ugly consistency beats no consistency... 2019-05-28 17:59:38 +01:00
Shish
5ec3e89884 php7.1 all the things 2019-05-28 17:31:20 +01:00
Shish
977c3db1e3 PHP7 type annotations 2017-09-21 05:21:42 +01:00
Shish
6febdec7b5 more explicit variable types 2016-06-19 23:05:57 +01:00
Daku
516488a625 load akismet via composer
note: we should probably be using a more recent library for this, but there doesn't seem to be any general ones..
2016-06-18 06:16:31 +01:00
Shish
cdcd762a52 more comments 2015-09-27 02:17:44 +01:00
Shish
ff13e58f8f clamp to a valid value 2015-09-26 20:03:30 +01:00
Shish
e482f97955 more clamping 2015-09-26 19:53:15 +01:00
Shish
5a8df90fd9 splitting up huge functions in ext/comment 2015-09-26 19:14:11 +01:00
Shish
90cd823ece fix liveness testing, and comments tests 2015-09-20 20:05:06 +01:00
Shish
9af5995dcc PHPUnit proof of concept 2015-09-20 20:03:29 +01:00
Shish
35a4f385b3 phpstorm tidying 2015-09-12 11:43:28 +01:00
Shish
83435e3266 set cookies on Page object 2015-08-03 15:49:36 +01:00
Shish
010b0620df add a user flag for bypassing comment checks 2014-11-30 13:52:29 +00:00
jgen
2a9f76d2f0 More comments, removing dead code, fixing small bugs. 2014-04-28 17:36:52 -04:00
jgen
4f51e942be Updating/Fixing/Adding more comments with the PHP Doc style. 2014-04-27 15:33:57 -04:00
jgen
298344048c Make these functions public to prevent scrutinizer from complaining. 2014-04-26 00:27:16 -04:00
jgen
4ec5a7ce52 Removing the closing PHP "?>" tag as per style guidelines. 2014-04-24 22:22:16 -04:00
Shish
da29912646 tidy up a bunch of lint errors 2014-03-17 22:05:37 +00:00
jgen
cebc197fba Merge branch 'develop' of git://github.com/shish/shimmie2 2014-02-23 03:11:09 -05:00
jgen
cf35bf82a8 Postgres doesn't support the DATETIME field. 2014-02-22 23:30:58 -05:00
jgen
e30520a5ef Fixing typo. 2014-02-22 23:23:23 -05:00
jgen
9892d1f7fd PostgreSQL does not support INDEX() inside the CREATE TABLE method. You must create the index as a separate query. Fortunately MySQL also support this way of doing things as well. 2014-02-22 23:02:11 -05:00
Daku
16bb38f343 onSearchTermParse regex should be case insensitive 2014-02-15 21:26:31 +00:00
Daku
325da11119 artist/comment/numeric_score metatags now work using :
also updated docs
2014-01-13 09:13:56 +00:00
jgen
4635f333ae This should have been moved earlier in the fix for Issue 346. 2013-12-07 23:16:20 -05:00
jgen
1c8d07983e Fix for PHP Notice being generated.
"PHP Notice:  Trying to get property of non-object in /comment/main.php on line 325"
Details: We don't need to try and get comments for images that don't exist. This might also help speed things up a bit as it should eliminate an unnecessary database query.
2013-12-05 19:50:21 -05:00
jgen
a7ab12abdd Fix for issue 346 - "Only first page of comments is shown" 2013-12-03 14:39:12 -05:00
Shish
1b73dd4ddc add 'hellbanned' user class, with support from the comments extension 2013-09-09 13:41:08 +01:00
Shish
07304861f3 log IDs of things 2013-08-30 00:19:46 +01:00
pachuco
ef8c60f032 Things were fetched from the currently logged user instead of the viewed one. My bad. 2012-12-18 17:29:07 +02:00
pachuco
f6f2638003 *Total number of pages correctly calculated for user comments
*Page number sanity checks for both user comments and site comments
2012-11-24 20:28:49 +02:00
Shish
fff8318f1f offset after limit 2012-10-17 00:05:48 +01:00
Shish
112130b8ad the start of full per-user comment history 2012-10-15 21:48:55 +01:00
Shish
6abf65c062 option for making samefags public 2012-10-03 21:28:29 +01:00
Shish
38f7555d98 get rid of direct references to Database's engine 2012-06-24 00:57:55 +01:00
Shish
239e028662 flash messages everywhere~ 2012-06-10 04:21:03 +01:00
Shish
82cc77817a delete comments by IP 2012-06-09 16:08:29 +01:00
Shish
58c06893e1 if the comment succeeds, we still want to set the 'user tried to comment' cookie :P 2012-03-19 20:05:19 +00:00
Shish
ee4b223f65 comment_anon bool -> create_comment perm 2012-03-19 13:17:47 +00:00
Shish
a23498a8d7 more recently updated comments 2012-03-15 06:17:19 +00:00
Shish
9e65732ea1 mysql ignores the FK names anyway, so all they were doing was bothering me ~_~ 2012-03-11 01:52:25 +00:00
Shish
97eb527714 named constraints 2012-03-10 19:38:50 +00:00
Shish
6c459c8323 make it so 2012-03-10 19:13:41 +00:00
Shish
a2d2ceb015 foreign keys delete comments now 2012-03-10 19:07:40 +00:00
Shish
f62edc3e83 add FKs for comments 2012-03-10 19:07:02 +00:00
Shish
37672bc1ee comment schema wibbles 2012-03-10 18:57:35 +00:00
Shish
569e93cd6b postgres requires a sequence name to be passed to get_last_insert_id 2012-03-08 02:55:04 +00:00
Shish
58d533ceb9 put a snippet of each comment in the event log 2012-03-08 02:36:21 +00:00
Shish
6222c0d093 redirect to the bottom of the thread when commenting 2012-02-22 13:25:03 +00:00
Shish
af7704825b use HTTP status codes with error messages 2012-02-16 15:37:05 +00:00
Shish
c2bf42ef5a less passing of $page 2012-02-15 08:59:24 +00:00
Shish
5f4f941444 half-logged-in only for one day 2012-02-09 17:11:03 +00:00
Shish
912f096d8c give nocache cookies to people who /attempt/ to post on old forms, not just those who succeed 2012-02-09 17:07:36 +00:00
Shish
0698b780f9 remove regular Extension, have SimpleExtension take its place, optimise the event system based on SimpleExtension methods 2012-02-08 12:07:01 +00:00
Shish
0589f9d72e fine grained permission bits 2012-02-07 15:15:18 +00:00
Shish
4e1300631b Merge branch 'master' of github.com:shish/shimmie2 2012-02-05 04:25:58 +00:00
Shish
5843aae4f2 random unused global o_O 2012-02-05 04:20:42 +00:00
Shish
dab85e5f26 merge type hints 2012-02-02 14:16:14 +00:00
Shish
cc8f1f35a5 more type hints 2012-02-02 14:14:33 +00:00
Shish
dc6c173efd type hints for hiphop 2012-02-02 08:07:57 +00:00
Shish
b3d5878ce8 use the param 2012-02-02 05:24:06 +00:00
Shish
aed5e1a30e hand merge of speed tweaks 2012-01-31 13:20:43 +00:00
Shish
8192f278d5 different sql for different databases :( 2012-01-31 12:15:25 +00:00
Shish
ddf61714f6 argh sql syntaxes 2012-01-22 14:54:03 +00:00
Shish
f5edb4fb4e the 24 hour limit can apply to the page count too, making that also 70x faster 2012-01-20 05:24:29 +00:00
Shish
4c2adce744 limiting by date at the database level is ~70x faster than limiting by page at the PHP level 2012-01-20 04:34:06 +00:00
Shish
f100e6a9d4 5 may have been a little extreme 2012-01-20 04:05:54 +00:00
Shish
36e443e07d the algorithm for listing old comments pages is *really* inefficient; the first few pages are quick, page 100 can take a few seconds to generate... rule34 has over 100,000 pages of comments. Limit to the first few pages for now, as I don't know anyone who even goes past the front page. 2012-01-20 03:12:48 +00:00
Shish
8ba22d8fbc same for user-agent 2012-01-19 15:28:55 +00:00
Shish
7608107232 lib/askismet expects the referrer to either be set manually, or exist; if it doesn't exist we need to set it manually 2012-01-19 15:20:32 +00:00
green-ponies (jgen)
cd7de93a0a Changing for-loops to use pre-calculated values.
Rather than calculating the value each time.
2012-01-16 00:07:04 -05:00
Shish
1857075bd9 show comments made by user 2011-12-31 13:54:32 +00:00
Shish
3d0cdfff56 mark users who have commented as interacting 2011-03-23 11:40:32 +00:00
Shish
b481db493c cache recent comments and comment page count 2011-03-23 11:37:46 +00:00