Shish
977c3db1e3
PHP7 type annotations
2017-09-21 05:21:42 +01:00
jgen
d62304cf70
more linting
2017-03-09 22:28:48 -08:00
Shish
7be951b271
Convert tags from user-supplied string to array once, on input
...
This results in a fuckton of refactoring and code cancelling out
other code -- we no longer have a whole bunch of places trying
to support string params and array params, and doing their own
esaping and unescaping, never being quite sure if the data they've
been passed is escaped or not.
Also adds a bunch of type hinting, since we can now know what
data we're dealing with better.
2016-07-30 22:11:49 +01:00
Shish
cb73a0caa0
let's stop being php5.2 compatible
2016-06-19 23:23:34 +01:00
Shish
6febdec7b5
more explicit variable types
2016-06-19 23:05:57 +01:00
Shish
cdcd762a52
more comments
2015-09-27 02:17:44 +01:00
Shish
90cd823ece
fix liveness testing, and comments tests
2015-09-20 20:05:06 +01:00
Shish
9af5995dcc
PHPUnit proof of concept
2015-09-20 20:03:29 +01:00
jgen
317028a63b
More PHP Doc comments.
2014-04-29 01:33:03 -04:00
jgen
4f51e942be
Updating/Fixing/Adding more comments with the PHP Doc style.
2014-04-27 15:33:57 -04:00
jgen
8f60467848
This code doesn't seem to actually be used by anything at all.
2014-04-25 22:33:57 -04:00
jgen
ab3f9850e4
Removing the closing PHP "?>" tag as per style guidelines.
2014-04-24 19:01:47 -04:00
jgen
f67220f64b
From stack-overflow: The 'var' keyword is for declaring class variables in PHP4. It works in PHP5 but can raise an E_STRICT warning in from version 5.0.0 up to version 5.1.2, as it has been deprecated.
...
Changing to public as that is really what these variables are anyways.
2014-04-24 04:36:05 -04:00
Shish
f72bfbb050
fix indentation
2014-04-06 20:47:01 +01:00
Shish
c8aa3327a1
A bunch of small changes from scrutinizer-ci; some tidying, some actual bug fixes
2014-03-30 13:26:48 +01:00
jgen
7eb2bd9112
Trimming trailing blank space.
2014-02-22 15:42:09 -05:00
HungryFeline
7cf79171a8
Update extension.class.php
...
Fix my previous commit. Also put the results of the tests into variables so we don't need to check them again.
2014-01-01 18:25:28 +01:00
HungryFeline
fde6558a6f
Don't silently ignore invalid URLs
...
Scenario: Providing an invalid url via $_GET (wrong/missing extension or file isn't an image (also happens on download errors))
Behavior before: Silently redirect to index
Behavior after: Display error message
2014-01-01 01:41:11 +01:00
Shish
7dd929e5a8
remove a whole load of event->user variables that weren't used -- things should be using global user
2012-08-18 19:45:39 +01:00
Shish
5a6f146444
more detailed docs
2012-03-05 18:42:05 +00:00
Shish
88ee6ea148
get_theme_object is only used once, move it closer to where it's used
2012-03-05 14:21:41 +00:00
Shish
171a4b7c85
php syntax
2012-03-05 13:58:04 +00:00
Shish
383dd0088e
documentation updates
2012-03-05 13:56:36 +00:00
Shish
0698b780f9
remove regular Extension, have SimpleExtension take its place, optimise the event system based on SimpleExtension methods
2012-02-08 12:07:01 +00:00
Shish
2d334e08ea
How did this typo get back in here? :/
2012-02-05 05:06:55 +00:00
Shish
ee94aca3cd
missed a bit
2012-02-02 16:08:49 +00:00
Shish
dab85e5f26
merge type hints
2012-02-02 14:16:14 +00:00
Shish
52ff412b38
hiphop type hint placeholders
2012-02-02 13:58:48 +00:00
Shish
93540faca8
a note for the future
2012-02-01 17:00:44 +00:00
Shish
3d582dc0d9
protip: don't break everything
2012-01-27 19:08:17 +00:00
Shish
6e64857936
wibble towards being totally SimpleExtension based, as that's easier to programatically optimise
2012-01-27 18:16:46 +00:00
Thasan
9f8a49483f
check if thumbnail already exists before regenerating it, way to force regen.
2012-01-12 03:54:27 +02:00
Shish
3e6d5cec6f
rating event rather than database access
2011-12-25 14:35:55 +00:00
Daku
ee1fc7e3ae
Admin can now lock image while transloading.
2011-12-24 20:18:00 +00:00
Daku
cd11e75e40
Can now set rating/external source while uploading via the bookmarklets.
2011-12-23 21:27:38 +00:00
green-ponies (jgen)
17999cade8
Image Replace feature working, just needs more testing.
2011-08-25 21:35:59 -04:00
green-ponies (jgen)
f3b6fde7a5
Working on adding a "Replace Image" feature.
2011-08-24 20:53:53 -04:00
seinoxygen
115d992ff0
merged image zoom
2011-01-01 19:19:18 +00:00
Shish
7403fd7c87
Revert "checks for files without extensions, from AtomicDryad"
...
This seems to break something, such that uploading a jpeg results
in image size 0x0 (other bits seem to work though o_O)
Will take a look at what's up and re-commit later...
This reverts commit ead87d3934
2010-12-24 20:44:38 +00:00
Shish
ead87d3934
checks for files without extensions, from AtomicDryad
2010-12-22 21:43:00 +00:00
Shish
d80ccbe497
SimpleExtension priority framework
2010-05-28 13:06:18 +01:00
Shish
b34dc57f9e
this uses the warehouse too
2010-02-02 01:55:18 +00:00
Shish
af36f37902
documentation updates
2010-01-12 15:01:34 +00:00
Shish
572f84511a
lots of docs, and some internal changes
2009-07-21 07:38:53 +01:00
Shish
2471a8e2eb
docs
2009-07-21 07:38:46 +01:00
Shish
627ecdbf4c
lots of docs
2009-07-19 08:38:27 +01:00
Shish
d8e027b776
a load more tests
2009-07-19 04:49:14 +01:00
Shish
4abf2ac7dd
more tests
2009-07-16 20:21:28 +01:00
Shish
4765e51e7c
explanation and credit
2009-05-15 01:52:55 -07:00
Shish
8dd3f8cbc0
SimpleExtension, like Extension but with more Magic
2009-05-11 14:08:32 -07:00
