nits

ext/media/main.php

@@ -286,10 +286,6 @@ class Media extends Extension
         $matches = [];
 
         if (preg_match(self::CONTENT_SEARCH_TERM_REGEX, strtolower($event->term), $matches) && $event->parse) {
-            // Nothing to save, just helping filter out reserved tags
-        }
-
-        if (!empty($matches)) {
             $event->metatag = true;
         }
     }

ext/ouroboros_api/main.php

@@ -390,8 +390,7 @@ class OuroborosAPI extends Extension
                         $this->sendResponse(403, 'You cannot create new posts');
                     }
                 } elseif ($this->match('update')) {
-                    // Update
-                    //@todo add post update
+                    throw new SCoreException("update not implemented");
                 } elseif ($this->match('show')) {
                     // Show
                     $id = !empty($_REQUEST['id']) ? filter_var($_REQUEST['id'], FILTER_SANITIZE_NUMBER_INT) : null;

ext/setup/main.php

@@ -53,10 +53,7 @@ class SetupBlock extends Block
 
     public function __construct(string $title)
     {
-        $this->header = $title;
-        $this->section = "main";
-        $this->position = 50;
-        $this->body = "";
+        parent::__construct($title, "", "main", 50);
     }
 
     public function add_label(string $text)

ext/source_history/main.php

@@ -301,10 +301,7 @@ class SourceHistory extends Extension
 				ORDER BY date_set DESC LIMIT 1
 			', $select_args);
 
-            if (empty($row)) {
-                // we can not revert this image based on the date restriction.
-                // Output a message perhaps?
-            } else {
+            if (!empty($row)) {
                 $revert_id = $row['id'];
                 $result = $this->get_source_history_from_revert($revert_id);
 

ext/tag_history/main.php

@@ -302,10 +302,7 @@ class TagHistory extends Extension
 				ORDER BY date_set DESC LIMIT 1
 			', $select_args);
 
-            if (empty($row)) {
-                // we can not revert this image based on the date restriction.
-                // Output a message perhaps?
-            } else {
+            if (!empty($row)) {
                 $revert_id = $row['id'];
                 $result = $this->get_tag_history_from_revert($revert_id);
 

ext/user/main.php

@@ -430,7 +430,7 @@ class UserPage extends Extension
         } elseif (is_null($my_user->email)) {
             $this->theme->display_error(400, "Error", "That user has no registered email address");
         } else {
-            // send email
+            throw new SCoreException("Email sending not implemented");
         }
     }