jgen
|
bcd3f991de
|
Removing the closing PHP "?>" tag as per style guidelines.
|
2014-04-25 17:34:20 -04:00 |
|
jgen
|
b4e6c0b743
|
Explicitly check if we can actually find the image by Id.
|
2014-04-25 16:08:00 -04:00 |
|
jgen
|
5b5fd955b7
|
New exception type.
|
2014-04-25 16:07:30 -04:00 |
|
jgen
|
9acf6c7f19
|
Rename these class functions to prevent warnings from scrutinizer.
|
2014-04-25 15:57:23 -04:00 |
|
jgen
|
141ec53236
|
Rename these class functions to prevent warnings from scrutinizer.
|
2014-04-25 15:55:31 -04:00 |
|
jgen
|
478eb3a4cc
|
Linting: Check for null return value, and throw an exception if null.
|
2014-04-25 15:39:00 -04:00 |
|
jgen
|
7ef68b15f9
|
Fix indentation.
|
2014-04-25 15:38:15 -04:00 |
|
jgen
|
6724f2b75a
|
Make these functions public to prevent scrutinizer from complaining.
|
2014-04-25 14:17:44 -04:00 |
|
jgen
|
dcadfc395a
|
Move this code back down.
|
2014-04-25 14:14:22 -04:00 |
|
jgen
|
a7faefc5e0
|
Spelling.
|
2014-04-24 22:35:01 -04:00 |
|
jgen
|
b241390fa4
|
Removing the closing PHP "?>" tag as per style guidelines.
|
2014-04-24 22:34:45 -04:00 |
|
jgen
|
50686ac61e
|
More linting, fix PHPDoc style.
|
2014-04-24 22:29:29 -04:00 |
|
jgen
|
daee99c1bc
|
Removing the closing PHP "?>" tag as per style guidelines.
|
2014-04-24 22:28:53 -04:00 |
|
jgen
|
860af25550
|
Need to pull in the global $user variable.
|
2014-04-24 22:22:45 -04:00 |
|
jgen
|
4ec5a7ce52
|
Removing the closing PHP "?>" tag as per style guidelines.
|
2014-04-24 22:22:16 -04:00 |
|
jgen
|
780d5f8709
|
More linting. Explicitly declare these class variables, as well as comment out dead code.
|
2014-04-24 22:13:00 -04:00 |
|
jgen
|
6e4ae229ef
|
Explicitly declare this class variable
|
2014-04-24 19:13:41 -04:00 |
|
jgen
|
b3077d5bcd
|
Removing the closing PHP "?>" tag as per style guidelines.
|
2014-04-24 19:13:20 -04:00 |
|
jgen
|
2706f72ce4
|
Update and fix the PHPDoc comments.
|
2014-04-24 19:08:23 -04:00 |
|
jgen
|
4cc31df737
|
Update the comments to PHPDoc style guidelines.
|
2014-04-24 19:02:43 -04:00 |
|
jgen
|
ab3f9850e4
|
Removing the closing PHP "?>" tag as per style guidelines.
|
2014-04-24 19:01:47 -04:00 |
|
jgen
|
286e75bef0
|
Scrutinizer complains that these functions aren't defined, yet they really are.
|
2014-04-24 18:45:54 -04:00 |
|
jgen
|
709366b70c
|
Explicitly declare these class variables.
|
2014-04-24 18:44:46 -04:00 |
|
jgen
|
7b90331f02
|
Add missing semi-colon.
|
2014-04-24 16:56:04 -04:00 |
|
jgen
|
993aacaea5
|
Update comment to reflect that a bug has been filed with PHP-analyzer.
|
2014-04-24 16:55:34 -04:00 |
|
jgen
|
c4dcba1e91
|
Explicitly check for the existence of these properties before attempting to use them.
|
2014-04-24 05:37:26 -04:00 |
|
jgen
|
7e41194b7f
|
Shish you are too clever for scrutinizer-ci.
|
2014-04-24 05:29:02 -04:00 |
|
jgen
|
ce524e8729
|
This variable does exist, it is actually pulled from the database. Making it explicit for the linter.
|
2014-04-24 05:25:12 -04:00 |
|
jgen
|
e2f5c7a6ec
|
Check for null, just in case.
|
2014-04-24 05:09:38 -04:00 |
|
jgen
|
0501e05cff
|
Comment out dead code/vars.
|
2014-04-24 05:09:16 -04:00 |
|
jgen
|
332c8538b7
|
Change the function syntax to quiet JSHint.
|
2014-04-24 04:46:23 -04:00 |
|
jgen
|
868f8c9225
|
Commenting out dead variables and dead code.
|
2014-04-24 04:44:28 -04:00 |
|
jgen
|
f9c8a1720e
|
Comment out dead variables.
|
2014-04-24 04:41:13 -04:00 |
|
jgen
|
f67220f64b
|
From stack-overflow: The 'var' keyword is for declaring class variables in PHP4. It works in PHP5 but can raise an E_STRICT warning in from version 5.0.0 up to version 5.1.2, as it has been deprecated.
Changing to public as that is really what these variables are anyways.
|
2014-04-24 04:36:05 -04:00 |
|
jgen
|
67c087c30f
|
From stack-overflow: The 'var' keyword is for declaring class variables in PHP4. It works in PHP5 but can raise an E_STRICT warning in from version 5.0.0 up to version 5.1.2, as it has been deprecated.
Changing to public as that is really what these variables are anyways.
|
2014-04-24 04:30:58 -04:00 |
|
jgen
|
dbe30ad37d
|
Rename variable to make it more clear.
|
2014-04-24 01:36:30 -04:00 |
|
jgen
|
afc01fda5f
|
Prevent scrutinizer-ci from complaining about these fall-thoughs.
|
2014-04-24 01:36:04 -04:00 |
|
jgen
|
506e699f8a
|
Not sure if we really need the triple equals.
|
2014-04-24 01:15:30 -04:00 |
|
jgen
|
866d39a68e
|
The 'tags' box actually has a different ID.
|
2014-04-24 01:15:03 -04:00 |
|
jgen
|
51c145d5c9
|
Some more linting on the bookmarklet.js file.
|
2014-04-24 01:08:47 -04:00 |
|
jgen
|
4b90faf89d
|
Even more linting of JS files.
|
2014-04-24 00:55:14 -04:00 |
|
jgen
|
a105090039
|
Some more JS linting.
|
2014-04-23 23:39:09 -04:00 |
|
jgen
|
887f963e17
|
Add the jshint comment to alter how scrutinzer-ci deals with the js.
|
2014-04-23 23:38:53 -04:00 |
|
jgen
|
31501e48fe
|
More JS linting.
|
2014-04-23 23:31:20 -04:00 |
|
jgen
|
2dc6e054c8
|
These sorts are necessary on the header arrays, otherwise the relative priority of certain headers is not respected.
|
2014-04-23 23:28:05 -04:00 |
|
jgen
|
b775c007cd
|
Give these HTML headers some slight priority over the default value of 50.
|
2014-04-23 23:07:10 -04:00 |
|
jgen
|
a0ab3864c0
|
Push the headers for the chatbox even further down to make sure that jQuery is already loaded.
|
2014-04-23 23:01:51 -04:00 |
|
jgen
|
8cdf919827
|
More linting. This time of the JavaScript for the chat-box extension.
|
2014-04-23 22:43:42 -04:00 |
|
jgen
|
0bd031a269
|
Merge branch 'develop' of github.com:jgen/shimmie2 into linting
Manually resolved conflicts:
ext/chatbox/js/yshout.js
|
2014-04-23 22:42:30 -04:00 |
|
jgen
|
5eaa637bbb
|
Merge branch 'develop' of git://github.com/shish/shimmie2 into develop
|
2014-04-23 22:23:53 -04:00 |
|